Google Git
Sign in
chromium / chromium / src / efecf28e7df18a85150040d756a0d3e3e3d5c567
commitefecf28e7df18a85150040d756a0d3e3e3d5c567[log] [tgz]
authorYao Xiao <yaoxia@chromium.org>Tue May 20 19:52:33 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 20 19:52:33 2025
tree9ba160c1783d5eae703df6a9c72b38be8255b6c9
parent6bea080bf49b175d9019c4d6e765c31f0d35a0a0 [diff]
[Ad Tracker] Add tests to demonstrate unexpected behavior in redirect scenarios

Problem: When a redirecting script is about to execute,
`AdTracker::WillExecuteScript` gets only the *initial* URL. The tagging
and ancestor linking decision is based on this URL, leading to
unexpected behavior (e.g., If a script's initial URL is not on
filterlist, but it redirects to a URL that is, its subsequently
created frames/scripts are not tagged as ads).

This CL adds tests to demonstrate the current behavior, and adds
comments to make it clear that this is unwanted and should be fixed.

Bug: 417756984
Change-Id: I9f21af9ca495247e648c1af695b3822f60c18d76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6548216
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1462992}
1 file changed
tree: 9ba160c1783d5eae703df6a9c72b38be8255b6c9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. SECURITY_OWNERS
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.