Google Git
Sign in
chromium / chromium / src / f00061f30a53692d036294db2c7082a968d8917e
commitf00061f30a53692d036294db2c7082a968d8917e[log] [tgz]
authorJiewei Qian <qjw@chromium.org>Fri Dec 04 00:33:08 2020
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Dec 04 00:33:08 2020
tree689a8343dc333c53bfb8e208ba3492f810a9d728
parent1ae38e736ebdfe6559f080bb05988a5606bf812d [diff]
ui/ash: update GetNumberOfSettingsWindows calls to compare with unsigned int

This is a followup to https://crrev.com/c/2569191, which the method was
added. The callsite in chrome_new_window_client_browsertest.cc wasn't
changed to match the return type. This caused a mismatch so EXPECT_EQ is
asked to compare int with size_t, and can cause problem on certain build
configurations.

Change-Id: I092e0f0ea5d333359c8e11c39e7202f27e1849e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573556
Auto-Submit: Jiewei Qian  <qjw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833524}
1 file changed
tree: 689a8343dc333c53bfb8e208ba3492f810a9d728
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.