Google Git
Sign in
chromium / chromium / src / f00c2f7f43bac2779b769ff7967d848c78c15a65
commitf00c2f7f43bac2779b769ff7967d848c78c15a65[log] [tgz]
authorChristoph Schwering <schwering@google.com>Sat Jul 26 04:11:40 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Jul 26 04:11:40 2025
tree032d3c8ce7622d5bbc4b1cf93dcd6fba00b462b1
parent4682e864617746dc6ee183fe6a96de0a1082817b [diff]
[Autofill] Do not merge UNKNOWN_TYPE and HtmlFieldType::kUnrecognized

After this CL, AutofillType(HtmlFieldType::kUnrecognized).ToStringView()
no longer returns "UNKNOWN_TYPE" but "HTML_TYPE_UNRECOGNIZED".

That change affects the following callers:
- Some logging functions: They which benefit from distinguishing
  between UNKNOWN_TYPE and HtmlFieldType::kUnrecognized.
- autofill_feedback_data.cc: Same as logging.
- automation_app_interface.mm: Its doing reverse lookup that currently
  maps "UNKNOWN_TYPE" to
  HtmlFieldTypeToBestCorrespondingFieldType(kUnrecognized). That
  happens to work fine because the function returns UNKNOWN_TYPE.
  But this CL makes the reverse lookup more reliable.
- WebView: This change provides more information to the Autofill
  framework by distinguishing between UNKNOWN_TYPE and
  HtmlFieldType::kUnrecognized. This change is admissible because
  Autofill doesn't guarantee these strings to be stable.

Bug: 40100455
Change-Id: Ic61722c1e9228f8efa81f8e91f15f3cd788b3e6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6786127
Commit-Queue: Christoph Schwering <schwering@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1492395}
2 files changed
tree: 032d3c8ce7622d5bbc4b1cf93dcd6fba00b462b1
  1. .github/
  2. agents/
  3. android_webview/
  4. apps/
  5. ash/
  6. base/
  7. build/
  8. build_overrides/
  9. buildtools/
  10. cc/
  11. chrome/
  12. chromecast/
  13. chromeos/
  14. codelabs/
  15. components/
  16. content/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. net/
  33. pdf/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. clusterfuzz-data
  51. internal
  52. ios_internal
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .cursorignore
  59. .geminiignore
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. SECURITY_OWNERS
  87. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.