commit f08548b51cc2ab6de6134968d597b269187387d8
author Luciano Pacheco <lucmult@chromium.org> Tue Oct 04 04:18:49 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Oct 04 04:18:49 2022
tree c45cb022c62d37c24052adb67ca5b760efba00b0
parent a2754ca64c88b047ccb5d2ca7a6f47062419b916

Revert "SelectFileDialog: Convert from RefCounted to std::unique_ptr"

This reverts commit 270245f69a17180ac3e037e7746b20da0061e38f.

Reason for revert: Causing crashes crbug.com/1368648

Manually merged to preserve the cross-thread issue fixed in
CL:3924783.

Original change's description:
> SelectFileDialog: Convert from RefCounted to std::unique_ptr
>
> SelectFileDialog (SFD) being ref-counted has caused multiple issues
> due to its unclear life-cycle and because usually its owner implements
> the Listener which SFD also has a pointer to it.
>
> Changing to unique_ptr makes clearer the SFD ownership and its
> termination, solving the UAF that was one of the common issues.
>
> This CL change in summary:
> * Change declaration from scoped_refptr<> to unique_ptr<>.
> * For Closure/Bind referring to instances of SFD, replace with
> base::AsWeakPtr(instance)
>
> NOTE: The SelectFileDialogFactory should be refactored to return an
> unique_ptr instead of raw pointer. This will be in a follow up CL since
> this CL is already too big.
>
> The SelectFileDialogLinuxKde implementation was using Bind() to a
> method with return value and this is incompatible with WeakPtr, to
> work around this, I changed the return value `KDialogOutputParams` to
> be passed as a ref-counted output argument like explained in [1].
>
> [1] -https://source.chromium.org/chromium/chromium/src/+/main:base/task/task_runner.h;l=77
>
> Bug: 1316211
> Change-Id: Ia59877a392364d7ab7af98cbc19e7f9146f465cc
> Cq-Do-Not-Cancel-Tryjobs: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3764409
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Tomas Gunnarsson <tommi@chromium.org>
> Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
> Reviewed-by: Austin Sullivan <asully@chromium.org>
> Commit-Queue: Austin Sullivan <asully@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1051347}

Bug: 1316211, 1368648
Change-Id: I89b0b1f6d1732ab62e2c44f7a2a1629d3ce32626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3930092
Owners-Override: Robert Lin <robertlin@google.com>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Huanpo Lin <robertlin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1054522}