Google Git
Sign in
chromium / chromium / src / f09ada289b392ae3e6767dda9e6c6e591eeb3e23
commitf09ada289b392ae3e6767dda9e6c6e591eeb3e23[log] [tgz]
authorJihad Hanna <jihadghanna@google.com>Mon Apr 29 10:58:07 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Apr 29 10:58:07 2024
treef59eb1f900543f110bcb13c6b9cbb47198b66f19
parent33e5a3e9aa05172fbafe3cd81cf239ad0ff5c9ba [diff]
Fix setting/caching fields' autofill state on JavaScript changes

After autofilling fields, sometimes JavaScript modifies some values, and
those modifications are either simple reformatting (inserting spaces
between CC number digits, formatting phone numbers, etc.) and sometimes
they change the value completely.

This CL:
- Adds logic to keep the field autofilled (in blink) when the JS changes
  are simple reformatting changes.
- Adds logic to reset the autofill state of the cached field when the
  JS changes are not trivial.

The changes in this CL were put behind a Finch feature flag in order to
asses the impact of the changes.

Bug: 40947225
Change-Id: I33bbc1268b1ffb13192737212ba6e7e4f4379520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374380
Reviewed-by: Dominic Battre <battre@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Jihad Hanna <jihadghanna@google.com>
Cr-Commit-Position: refs/heads/main@{#1293598}
31 files changed
tree: f59eb1f900543f110bcb13c6b9cbb47198b66f19
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.