commit f13743d651fc40015d1be01dd0e66a33192d82fc
author Mark Pearson <mpearson@chromium.org> Fri Jul 07 22:00:52 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 07 22:00:52 2023
tree 64b9576c95707b99b888245db77b591bb02c3a8e
parent aca11fc992ac12ee94cff9ff2e8cf75e78e6bdfb

Metrics Logging - Enable Network Time Tracker

The framework to use network time tracker in metrics logging was landed
in a disabled form in
https://chromium-review.googlesource.com/c/chromium/src/+/3032615/
At that time, compiling in network time tracker caused errors on
certain Android bots.  These errors came from a library brought in
through transitive includes from webm.  Those errors in webm have
now been cleaned up.

In the process of enabling the network time tracker, fix a bug exposed by tests:

The creation of NetworkTimeTracker in BrowserProcessImpl::PreMainMessageLoopRun() was guarded by the feature flag network_time::kNetworkTimeServiceQuerying.  This guard didn't do much, as a NetworkTimeTracker would be created automatically the first time it was accessed.  (This use was unguarded.)  This change removes the guard.

(I considered applying the guard consistently everywhere, but it seems many tests rely on having an existing NetworkTimeTracker, even one that doesn't run queries for remote times.  Removing the guard is the simplest way to keep the status quo.  If someone wants later to guard all creations and fix all the test assumptions, that can be done elsewhere.)

Bug: 1257449,1278829
Change-Id: I2d63bfdf0b0b08196f870c999443b644953adbd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3322058
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Luc Nguyen <lucnguyen@google.com>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1167657}