Google Git
Sign in
chromium / chromium / src / f1c750c770fb0eceea8651929a6158007eaf8476
commitf1c750c770fb0eceea8651929a6158007eaf8476[log] [tgz]
authorElias Klim <elklm@chromium.org>Fri Jul 19 17:20:36 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jul 19 17:20:36 2024
treea45ad6558e809a9771957785f1b82577bc2cf09a
parent53b644fe11c7f69b63db54db5b42683ff3f3da8f [diff]
Reland "[Permissions] Deleting last site-list item focuses the list header"

This reverts commit 1cf9cde8a80dfa0d9161f814ce76c93ad78641fa.

Reason for revert: Previous revert was incorrect. This cl has nothing to do with `LLVM ERROR: out of memory`

Original change's description:
> Revert "[Permissions] Deleting last site-list item focuses the list header"
>
> This reverts commit ffe0514baadbde581f2d07e5053d964954e9c375.
>
> Reason for revert:
> LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8741999398900018081
>
> Sample failed build: https://ci.chromium.org/b/8741999398900018081
>
> If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5712836&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8741999398900018081&type=BUG
>
> Original change's description:
> > [Permissions] Deleting last site-list item focuses the list header
> >
> > This CL is a follow up of https://crrev.com/c/5677290 and it moves
> > focus if the last sites list entry got removed from `site-list-entry`.
> >
> > Bug: 327666409
> > Change-Id: I93fa6008bf53125a88f836a7941343f7a274b09a
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5712836
> > Commit-Queue: Elias Klim <elklm@chromium.org>
> > Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1330084}
> >
>
> Bug: 327666409
> Change-Id: I1f573ca2f8719d4032cc59844022e398988025c1
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5725724
> Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
> Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
> Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1330214}

Bug: 327666409
Change-Id: I2519b380bfcbe3a71926b16f320814033c2c3a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5724692
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org>
Commit-Queue: Elias Klim <elklm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1330337}
4 files changed
tree: a45ad6558e809a9771957785f1b82577bc2cf09a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.