Google Git
Sign in
chromium / chromium / src / f224cffcbff3cc805825884f6f121321d841fc46
commitf224cffcbff3cc805825884f6f121321d841fc46[log] [tgz]
authorSky Malice <skym@chromium.org>Mon Sep 19 21:25:27 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Sep 19 21:25:27 2022
treed683e6f46df1defc86a5e58b2d64532fb861b08c
parent865eb8fd2bf95551a71d4e4aed8769e9e7730406 [diff]
Set drawable to enabled before drawing.

The tint for some status view icons, such as the globe, is a color
state list that applies alpha when disabled. Previous change
https://crrev.com/c/3893112 converted between drawables without
attaching the drawable to a view. This left all state fields in their
default (false) state. This caused the color state list to use the
disabled version, with a large alpha value, causing the icon to show
up "lighter".

The approach taken in this CL and in https://crrev.com/c/3893112
effectively break the ability of the color state list to dynamically
change the tint based on the state of the view. However the StatusView
doesn't currently rely on this, so it doesn't matter.

Bug: 1365377
Change-Id: I1ae122b54989bb61c6c19bbe01befd81a6a5af43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3905634
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1048791}
1 file changed
tree: d683e6f46df1defc86a5e58b2d64532fb861b08c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.