commit | b455227428979e24f66de2f45c9180f33f4a8adf | [log] [tgz] |
---|---|---|
author | Victor Hugo Vianna Silva <victorvianna@google.com> | Thu Nov 26 18:01:15 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 26 18:01:15 2020 |
tree | 0a44efdc7d8b2ae83fdd814fa2b9ca8e94a4e05f | |
parent | 76540e6f658c91f24869442567a78d5b54e8006f [diff] |
[sync] Rewrite setSyncEncryption() chrome://settings JS API This API was called when the user created a new sync encryption passphrase or entered an existing one. This CL improves both its semantics and implementation. - Instead of having a set_new_passphrase flag to distinguish new/existing passphrases, the API is split in set[Encryption/Decryption]Passphrase(). The implementations are mostly disjoint and there's a clear separation now (the old code would even ignore set_new_passphrase sometimes). This also mimics the signatures from other layers. - As per the linked bug, the APIs now receive only what's necessary (the passphrase string) instead of an entire SyncPrefs object. - Following a suggestion from an old TODO [1], the "return values" are now simply whether the passphrase was successfully set or not, instead of returning what the behavior of the UI should be (PageStatus). This makes them less coupled with the existing callers. - The Profile.SyncCustomize histogram is now recorded closer to where the passphrase updates happen. This may ultimately cause changes in the metric, but at least something meaningful will be recorded now. Seems the histogram wasn't actively watched anyways (it expired twice). The obscure buckets SYNC_ENCRYPT and SYNC_PASSPHRASE are also respectively renamed to SYNC_CREATED_NEW_PASSPHRASE and SYNC_ENTERED_EXISTING_PASSPHRASE. [1] https://source.chromium.org/chromium/chromium/src/+/b44f7fc1be34f23c0e052cac0554675eb34b2272:chrome/browser/ui/webui/settings/people_handler.cc;l=593 Change-Id: Id820d08c89fb5d79ffbc62ff9c4f6534c24df4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556961 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by: Monica Basta <msalama@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#831393}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.