Google Git
Sign in
chromium / chromium / src / f2c25a0d34a29b899674094edc006d5f613db8b6
commitf2c25a0d34a29b899674094edc006d5f613db8b6[log] [tgz]
authorluci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>Sat Jul 26 23:17:25 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Jul 26 23:17:25 2025
tree84563ab7f5c38aaba391cc2ab2ccc7ffbdc3f87e
parent488399db6726ea3aa925b1b391c382ab59d5ae1a [diff]
Revert "Add @NullMarked to chrome/android/j/s/o/c/chrome/browser/download part3"

This reverts commit 488399db6726ea3aa925b1b391c382ab59d5ae1a.

Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8708243450379312385

Sample failed build: https://ci.chromium.org/b/8708243450379312385

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6766997&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8708243450379312385&type=BUG

Original change's description:
> Add @NullMarked to chrome/android/j/s/o/c/chrome/browser/download part3
>
> Bug: 389129271
> Change-Id: I2ba1bcfbe7a02404a84dbe7030ba42ab92ff7612
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6766997
> Reviewed-by: Min Qin <qinmin@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Auto-Submit: Shu Yang <shuyng@google.com>
> Commit-Queue: Shu Yang <shuyng@google.com>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1492470}
>

Bug: 389129271
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: If1cdaccbcccb56c3bbe1d26821eba4665caf0fbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6789776
Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1492471}
9 files changed
tree: 84563ab7f5c38aaba391cc2ab2ccc7ffbdc3f87e
  1. .github/
  2. agents/
  3. android_webview/
  4. apps/
  5. ash/
  6. base/
  7. build/
  8. build_overrides/
  9. buildtools/
  10. cc/
  11. chrome/
  12. chromecast/
  13. chromeos/
  14. codelabs/
  15. components/
  16. content/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. net/
  33. pdf/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. clusterfuzz-data
  51. internal
  52. ios_internal
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .cursorignore
  59. .geminiignore
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. SECURITY_OWNERS
  87. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.