commit | f2de9a64bfccda835b78bfa1c0566e13c39c6721 | [log] [tgz] |
---|---|---|
author | Christian Flach <cmfcmf@chromium.org> | Thu Oct 12 09:09:34 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Oct 12 09:09:34 2023 |
tree | 4779c7186f7199d87d27d1af91a168b60d55d83c | |
parent | 04b4bf615441cefd8613f3d621ea80d337f7c234 [diff] |
iwa: Do not use `kIsolatedWebApps` feature flag directly This feature flag should almost never be used directly and instead `content::IsolatedWebAppsPolicy::AreIsolatedWebAppsEnabled` should be used. In the renderer, the `switches::kEnableIsolatedWebAppsInRenderer` command line flag should be used. This CL replaces two uses: - `apps_section.cc` used the feature flag but should use `AreIsolatedWebAppsEnabled`. - `runtime_features.cc` uses both the feature flag and the command line switch to enable Direct Sockets. Therefore, we can remove the enablement based on the feature flag and instead make sure that the command line switch is set properly in `ShellContentBrowserClient` so that tests that set the feature flag continue to work. Bug: b:289356220, 1481737 Change-Id: I61db6ae7414945d7455c43b43a1643fec45b52c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4898690 Reviewed-by: Andrew Rayskiy <greengrape@google.com> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Christian Flach <cmfcmf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1208724}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.