Google Git
Sign in
chromium / chromium / src / f311709cf1f7bacfeb17a330b91e4243b41f030f
commitf311709cf1f7bacfeb17a330b91e4243b41f030f[log] [tgz]
authorDominik Röttsches <drott@chromium.org>Wed Jul 03 18:19:50 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 03 18:19:50 2024
tree341174b72a97ea56f1ef6728664293fa60cc9c20
parent44d8991612aa789c8b004c2f193263ba942c9adc [diff]
[Fontations] Fix unique name lookup font indexing unittests

Fix the unittests by using Fontations for finding a distinct offset in
the font file (collection or single font file) that can be used as a
marker to corrupt the file (write zeroes) before or after.

Introduce an CXX FFI to call Fontations for finding the offset to the first font table in the font file. This FFI will be used in a follow-up CL to move the actual font name table reading to Fontations.

The unit tests tried to find a number of tables structure in the font
file. They did not differentiate between a TrueType collection (ttc)
file, and a regular font file, which lead to parsing errors. The
original intention was to use the parsed offset to intentionally corrupt
font files for testing to test the robustness of font indexing. The
incorrect parsing lead to somewhat random corruption of font files. This
was enough to make FreeType fail to read the files (as intended), but
when moving to Fontations, in some instances Fontations was able to read
information from the font files, which breaks the unit tests.

Bug: chromium:349952802
Change-Id: Ic65589727abf46e2157cb8a858882d0ab7154c51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5673355
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322910}
4 files changed
tree: 341174b72a97ea56f1ef6728664293fa60cc9c20
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.