commit f32a918bb5f1b7b2dbe6bfffc872d63ceebb788c
author Eva <evih@google.com> Fri Sep 17 19:47:07 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Sep 17 19:47:07 2021
tree a7f8a9772b2abda26d85985810a356e8c202dec4
parent 2bc3d7e11aba37badf48b04773333116643a4592

[Autofill] Deep compare forms and fields when extracting forms

In this change, we introduce a new deep comparison function for FormData
and FormFieldData structs used when updating the FormCache.

The old ExtractNewForms() is responsible for extracting new and changed
forms in the DOM. It is called on page load or when a new field is added
(or called by TriggerReparse()). When called, it also re-extracts forms
that have other changes than having a new field.

This CL changes the behaviour of the kAutofillUseNewFormExtraction
experiment to have the same behaviour as the non-experimental
ExtractNewForms().

To this end, this CL introduces a DeepEqual() function for FormData and
FormFieldData. These functions compare *all* attributes. To improve
performance, they do a shallow comparison first. Preliminary testing
has shown that the shallow and deep comparisons differ in 4% of
comparisons; a metric is added in a followup CL.

To better reflect this behaviour of re-extracting not just new forms or
forms with new fields but all changed forms, this CL renames the
function to UpdateFormCache()

Bug: 1215333
Change-Id: I7af67bb485bdb28cd7b13bb6873c3d7e1462f749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138805
Reviewed-by: Christoph Schwering <schwering@google.com>
Reviewed-by: Matthias Körber <koerber@google.com>
Commit-Queue: Eva Herencsárová <evih@google.com>
Cr-Commit-Position: refs/heads/main@{#922624}