[ASH] Show IPH at onPageLoadFinished The timing CustomTab history IPH shows feels way too early in the tab lifecycle (almost immediately on url load). This is because it uses TabObserver#onPageLoadStarted to trigger the UI. Upon inspection, other IPHs observing tab events all rely on TabObserver#onPageLoadFinished. This CL updates CustomTab history IPH to observe load-finish signal instead. Bug: crbug.com/324842054 Change-Id: I2db194d23779d412f7b4a4af0c299fd28be84461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5980691 Reviewed-by: Sinan Sahin <sinansahin@google.com> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/main@{#1378431}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.