commit | f3409d2ba8a8dcfb3b5b1ac1a89d3fba835395aa | [log] [tgz] |
---|---|---|
author | Dan Clark <daniec@microsoft.com> | Tue May 14 21:09:13 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue May 14 21:09:13 2024 |
tree | 7a4cfd209d3bb61dce8c4f2ef7b23c9b6a783545 | |
parent | 7c2f4854bac9c0799bc074b7d95dc80e55841f95 [diff] |
[Interop] Apply listitem role even if <li> doesn't have layout The <li> element is supposed to get the listitem role if its parent is an element with a list role [1]. This role was failing to be applied if the <li> or its parent had display:contents because RoleFromLayoutObjectOrNode() has an early return if the element doesn't have layout. Fix the issue by lifting the code to apply the listitem role out of RoleFromLayoutObjectOrNode() so that the role gets applied regardless of whether the element has layout. [1] https://www.w3.org/TR/html-aam-1.0/#el-li Bug: 340200016 Change-Id: I7960e2954ae5650d03e40c6355aa3c665022502f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5535751 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1300878}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.