"Reland" Introduce coordinator to manage ZoomBubbleView lifecycle This is a reland of commit a8caf1db2225b01147870e86f0b033d3e5f2ebba - Issue and fix: A crash was happening during the browser shutdown because the BrowserWindow was null. The zoom bubble close is async. Therefore, the BrowserWindow access should be checked since it can occur during browser shutdown time. - Original change's description: A re-entrant call sequence during the creation of the zoom bubble could lead to a crash. An asynchronous event, such as a focus change, occurring during the `ShowBubble` method could trigger a call to `CloseCurrentBubble`. This would nullify the static `zoom_bubble_` pointer before it was fully initialized, causing a null pointer dereference on the next line on the instantiation. The issue has been previously mitigated by checking the `zoom_bubble_` before accessing it. This change fixes the crash by introducing `ZoomBubbleCoordinator`, a new class responsible for managing the lifecycle of `ZoomBubbleView`. The coordinator is owned by the browser window, providing a clear ownership model and eliminating the problematic static instance. By centralizing the creation, showing, and hiding of the bubble within the coordinator, this refactoring prevents the re-entrancy issue and ensures the bubble's state is always consistent. BYPASS_LARGE_CHANGE_WARNING Change-Id: I0a4a3d992b92ceb2c0e07aadbed429a187d53a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7017450 Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Daniel Soromou <koretadaniel@chromium.org> Reviewed-by: Eshwar Stalin <estalin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1527033}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.