commit f39adacbbb7894ce056921763a50071329316507
author Steinar H. Gunderson <sesse@chromium.org> Tue Jun 20 13:33:52 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 20 13:33:52 2023
tree 4d34ee3662da9f601da63446b56855d86086b437
parent b1d33eb31610ec6ea61efad77b58b18c8aa7d773

Remove unused parameters from ExpandCascade().

We never use these anywhere, and evidently, the compiler was unable
to optimize them out completely, so this speeds up StyleCascade
slightly.

Style perftests (Alder Lake, LTO but no PGO):

Initial style (µs)     Before     After    Perf      95% CI (BCa)
=================== ========= ========= ======= =================
ECommerce                3967      3903   +1.6%  [ +0.9%,  +2.3%]
Encyclopedia            33572     33247   +1.0%  [ +0.3%,  +1.9%]
Extension               48158     47869   +0.6%  [ +0.2%,  +1.0%]
News                    17326     17205   +0.7%  [ -0.3%,  +1.5%]
Search                   5558      5541   +0.3%  [ -0.8%,  +1.1%]
Social1                 11159     11048   +1.0%  [ +0.2%,  +1.8%]
Social2                  6880      6765   +1.7%  [ +0.8%,  +2.6%]
Sports                  21313     21192   +0.6%  [ -0.4%,  +1.4%]
Video                   15915     15823   +0.6%  [ -0.0%,  +1.3%]
Geometric mean                            +0.9%  [ +0.3%,  +1.4%]

Recalc style (µs)      Before     After    Perf      95% CI (BCa)
=================== ========= ========= ======= =================
ECommerce                4197      4099   +2.4%  [ +2.0%,  +2.8%]
Encyclopedia            22030     21726   +1.4%  [ +0.7%,  +2.0%]
Extension               41828     41323   +1.2%  [ +0.8%,  +1.5%]
News                    11009     10892   +1.1%  [ +0.2%,  +1.9%]
Search                   2300      2286   +0.6%  [ +0.1%,  +1.2%]
Social1                  6377      6329   +0.8%  [ -0.0%,  +1.5%]
Social2                  4977      4881   +2.0%  [ +1.4%,  +2.6%]
Sports                   8327      8269   +0.7%  [ +0.1%,  +1.3%]
Video                    8578      8513   +0.8%  [ +0.1%,  +1.4%]
Geometric mean                            +1.2%  [ +0.8%,  +1.6%]

Change-Id: I3f3123b9ee223237e85eaa311824fa35e2b5506f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4622726
Commit-Queue: Steinar H Gunderson <sesse@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1159978}