commit f39f87b2865ffb78027b68d9cc343133dc3aa2d9
author Chris Fredrickson <cfredric@chromium.org> Mon Jul 11 11:34:04 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 11 11:34:04 2022
tree c9b9a653513da158689926d1ff53fd3cad1cee01
parent 4ebadab9ba3984d91690fa64c441bdc480bc88cb

[Code Health] Rewrite test helpers to return values.

It's better to return a value instead of doing assertions in the
helper, so that test failures include the line number in the test
body, rather than the line number in the test helper.

This also grants tests the flexibility to differentiate expectations
from assertions during test setup (e.g. in api_browsertest.cc).

This CL also adds two expectations that were mistakenly omitted from
https://crrev.com/c/3749906.

Change-Id: Id22f16f020cf66cedaf20f7e17048a5905b322bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3750281
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Chris Fredrickson <cfredric@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1022652}