Google Git
Sign in
chromium / chromium / src / f42d08c87e18507bc0a4bc8dab55c3590de998be
commitf42d08c87e18507bc0a4bc8dab55c3590de998be[log] [tgz]
authorBao-Duy Tran <tranbaoduy@chromium.org>Thu May 25 08:05:42 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu May 25 08:05:42 2023
tree466f07398ebdd72cfa46a072fc45c9c7438a1cb4
parent49d8691ff284317856ce64b8a47fa35fb5cb858e [diff]
Remove bespoke feature names support in ImeService::IsFeatureEnabled().

ImeService::IsFeatureEnabled() is the implementation of the
corresponding "C" API of CrOS IME Service Container, for use by
CrOS 1P IME shared lib. This ensures that the API is consistent
and only considers official CrOS feature flag names used across
the rest of CrOS, instead of inventing its own bespoke names.

At this point (now that http://cl/532373120 has landed in CrOS),
1P IME shared lib no longer invokes the API with these bespoke
feature flag names.

Bug: b:218815885
Change-Id: Ib007a4769759216ad3ef7d8a97a5bf9e585e86c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4541900
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org>
Reviewed-by: Michelle Chen <michellegc@google.com>
Cr-Commit-Position: refs/heads/main@{#1148945}
2 files changed
tree: 466f07398ebdd72cfa46a072fc45c9c7438a1cb4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.