commit f4387b68dcc76cff2cb6e72ed4ac047c211f6b26
author Javier Contreras Tenorio (from Dev Box) <javiercon@microsoft.com> Wed Jul 24 01:13:16 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jul 24 01:13:16 2024
tree 0dd19a12bc60a177754dddd090488fcb8a928366
parent d4a5daf47e784af3b501432c817af5568dfadef7

[views-ax] Pausing a11y events until view is added to tree

This CL makes it so we don't fire accessibility events until the view
is added to the tree (i.e. is connected to a RootView).

This is to prevent any events from being fired when accessible property
setters are used in the construction of any views, as these shouldn't
fire events.

In order to do this, the RootView's
ViewAccessibility::pause_accessibility_events_ is always set to true,
and then when a View gets added as a child to any View we change the
value of this variable in this view to whatever that view's parent
value for `pause_accessibility_events_` is. This walk down the
descendants shouldn't affect performance since this walk was already
being done with `UpdateFocusableStateRecursive`.

The unit test changes are to account for this behavior, plus some
more tests were added. No further unit test modifications should be
necessary as long as the View in question is added to a Widget first.

This CL is part of the ViewsAX project:
https://docs.google.com/document/d/1Ku7HOyDsiZem1yaV6ccZ-tz3lO2XR2NEcm8HjR6d-VY/edit#heading=h.ke1u3utej413

Bug: 325137417
Change-Id: Iad32b1918be2c8d88e5a8aad1e53a7443201805e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5673026
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Commit-Queue: Javier Contreras <javiercon@microsoft.com>
Reviewed-by: Jiaming Cheng <jiamingc@chromium.org>
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1332086}