Google Git
Sign in
chromium / chromium / src / f48bd25089e7fd7f988f98456ae1dd5a183a2a5c
commitf48bd25089e7fd7f988f98456ae1dd5a183a2a5c[log] [tgz]
authorTsuyoshi Horo <horo@chromium.org>Tue Apr 15 01:15:21 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 15 01:15:21 2025
tree6a33644a54d27b9de69e4e772ea7343ac8f86769
parent6ffd8e08bbf598c726987e878cb5d0d85f92cae6 [diff]
network: Refactor URLLoader::BuildResponseHead into url_loader_util

Extract the logic for constructing mojom::URLResponseHead from
URLLoader::BuildResponseHead into a new utility function
network::url_loader_util::BuildResponseHead.

This refactoring aims to:
- Decouple the response head construction logic from the URLLoader
  class.
- Improve maintainability by placing the construction logic in a
  dedicated utility file.

The new function takes the necessary data (URLRequest, parsed request
cookies, PNA address spaces, load options, etc.) as parameters. The
URLLoader method now simply gathers these parameters from its member
variables and state, and calls the utility function.

An explicit CHECK is added in URLLoader before calling the utility
function to ensure consistency regarding `request_cookies_` and the
`include_request_cookies_with_response_` option, which was previously
handled within the original method.

No behavior change is intended by this refactoring.

Bug: 408106280
Change-Id: Ib970ad0b5a23a2d5e790164e80ef3179fb048989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6450656
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1446886}
3 files changed
tree: 6a33644a54d27b9de69e4e772ea7343ac8f86769
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.