Google Git
Sign in
chromium / chromium / src / f4960c36731e9a56fc72c31f6b000c4500d71ca7
commitf4960c36731e9a56fc72c31f6b000c4500d71ca7[log] [tgz]
authorAshley Prasad <ashleydp@google.com>Wed Jun 15 20:27:27 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 15 20:27:27 2022
tree38efb24540eef1593d6980773bdb4519b05675bd
parent5e99236880551eb96135619972c56eee53478820 [diff]
feedback: add feedback-user-consent-granted

- Updates mojom struct Report to include boolean to track if user has
  granted consent to Google to follow up using provided email. See
  go/feedback-user-consent-faq for more information on user consent.
- Add checkbox and related localization string to display consent
  messaging when email provided.
- Disables and sets consent to false when email not provided.
- Test UI updates correctly and report sends expected data.
- Tests feedback_data correctly adds consent key-value pair depending
  on feedback-user-consent-granted value.

Screenshot: http://screen/3HhNMTHkrrHqums

Bug: b:234065024
Test: Ran `browser_test --gtest_filter=ChromeOsFeedbackDelegateTest*`
and deployed to DUT and sent a test report (http://doc/1CuR8SSQLciAXuysYcL3QP7cQ-LsXb86nCvC0NYJMuCo).

Change-Id: Ie9fd1b6608d3e6d1aea7dba5486879af2818aac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3703857
Reviewed-by: Xiangdong Kong <xiangdongkong@google.com>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Ashley Prasad <ashleydp@google.com>
Cr-Commit-Position: refs/heads/main@{#1014614}
9 files changed
tree: 38efb24540eef1593d6980773bdb4519b05675bd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.