commit f4abc2e91c68efe4011e1b75ef8ebaedb9c92b64
author Thomas Nguyen <tungnh@chromium.org> Mon Jan 15 13:30:42 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jan 15 13:30:42 2024
tree ee99bbe9dd156ef00bd826ff97762e35fdece922
parent 8cd6540d3438f4365218a7b071607ccf63ae1ac3

[gardening] Disable flaky tests on Windows

Disable flaky tests SidTest.FromNamedCapabilityVector and
SidTest.NamedCapability.

Bug: 1518451
Change-Id: I8000df572471cd0c5b494dfc2e4cbc090ad7a078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5198367
Owners-Override: Thomas Nguyen <tungnh@chromium.org>
Reviewed-by: Florian Jacky <fjacky@chromium.org>
Commit-Queue: Thomas Nguyen <tungnh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1247139}

base/win/sid_unittest.cc

diff --git a/base/win/sid_unittest.cc b/base/win/sid_unittest.cc
index 802ae21..3990c2da 100644
--- a/base/win/sid_unittest.cc
+++ b/base/win/sid_unittest.cc
@@ -15,6 +15,7 @@
 #include "base/win/scoped_handle.h"
 #include "base/win/scoped_localalloc.h"
 #include "base/win/win_util.h"
+#include "build/branding_buildflags.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/abseil-cpp/absl/types/optional.h"
 
@@ -152,7 +153,13 @@
   }
 }
 
-TEST(SidTest, NamedCapability) {
+// TODO(crbug.com/1518451): Disable flaky tests.
+#if defined(OFFICIAL_BUILD) && BUILDFLAG(GOOGLE_CHROME_BRANDING)
+#define MAYBE_NamedCapability DISABLED_NamedCapability
+#else
+#define MAYBE_NamedCapability NamedCapability
+#endif
+TEST(SidTest, MAYBE_NamedCapability) {
   const std::wstring capabilities[] = {L"",
                                        L"InternetClient",
                                        L"InternetClientServer",
@@ -259,7 +266,13 @@
   ASSERT_TRUE(TestFromSddlStringVector({}));
 }
 
-TEST(SidTest, FromNamedCapabilityVector) {
+// TODO(crbug.com/1518451): Disable flaky tests.
+#if defined(OFFICIAL_BUILD) && BUILDFLAG(GOOGLE_CHROME_BRANDING)
+#define MAYBE_FromNamedCapabilityVector DISABLED_FromNamedCapabilityVector
+#else
+#define MAYBE_FromNamedCapabilityVector FromNamedCapabilityVector
+#endif
+TEST(SidTest, MAYBE_FromNamedCapabilityVector) {
   std::vector<std::wstring> capabilities = {L"",
                                             L"InternetClient",
                                             L"InternetClientServer",