commit f4dbdbc064a6c39c8f390625f55d580d1f2093eb
author Justin Donnelly <jdonnelly@chromium.org> Thu May 23 17:48:52 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu May 23 17:48:52 2024
tree 1041490a6074cba9b786465160e24239af66572c
parent c4471876da936ff617a3d09e008c77965c55d721

[lensoverlay] Expand search stack push and pop logic.

There are two major goals for this change:
- Remove the thumbnail from the searchbox when the user clicks a related search in the SRP.
- Ensure that pushing and then popping searches from the query history stack saves and restores all necessary state that the overlay and searchbox rely on.

Theoretically, these could have been handled in separate CLs but the code is related and I think it'll be easier to review and land together.

Specifically, this CL includes the following changes:
- Renames a number of variables to be more consistently named between corresponding values in the controller and in the `SearchQuery` struct.
- Adds `additional_search_query_params_` to the `SearchQuery` struct for saving and restoring.
- Has `AddQueryToHistory` infer when a search URL looks like it was a SRP click and then clears the searchbox thumbnail and overlay selection in this case.
- Has `PopAndLoadQueryFromHistory` restore additional state so that searchbox suggestions and search URLs are correct.
- Removes `LensOverlayController::IssueObjectSelectionRequest` and downstream code, which appear to be unused.

Bug: b:340591543, b:335718601, b:341804325, 342390515
Change-Id: I71c9afbb46f7ddf653f17a07093a54184156698d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5548877
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Juan Mojica <juanmojica@google.com>
Cr-Commit-Position: refs/heads/main@{#1305205}