commit f51b8376016190b3c67e391a8b03ddf7e111686f
author Fredrik Söderquist <fs@opera.com> Wed Mar 15 20:24:11 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Mar 15 20:24:11 2023
tree 4c4aac18222a267aa6cce74e299158fd937b4b61
parent 4bbafc7e90b7fbe81e57c21d8e6481a4d19869bf

Partial Revert "Use UpdateImageState() for src='' case in ImageLoader::UpdateFromElement"

This reverts commit 9974fcb2ba7b04dff7cf1ff4fbc6ce1f68578aaf.

Partial because we keep setting the `image_complete_` flag to true in
the src='' branch to not regress tests.

Reason for revert: May be causing crashes. See https://crbug.com/1424667

Original change's description:
> Use UpdateImageState() for src='' case in ImageLoader::UpdateFromElement
>
> This is basically open-coding UpdateImageState(nullptr), so use that
> instead.
>
> There is small difference in that UpdateImageState(...) will only call
> StopMonitoring(...) when |lazy_image_load_state_| is kDeferred, but that
> is the only state where the "monitor" should be active. Add a call to
> StopMonitoring(...) in ImageLoader::LoadDeferredImage() where the lazy
> state is changed to 'full image' without stopping the monitor. We still
> ensure that |lazy_image_load_state_| is kNone when done, although that
> seems unnecessary.
>
> UpdateImageState(...) also sets the |image_complete_| flag to reflect
> the "cleared" state.
>
> Bug: 1000273, 1014449
> Change-Id: Ie6bb57e4b410c75708494d1f912eb5916f91194a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4324017
> Reviewed-by: Dominic Farolino <dom@chromium.org>
> Commit-Queue: Fredrik Söderquist <fs@opera.com>
> Cr-Commit-Position: refs/heads/main@{#1116510}

Bug: 1000273, 1014449, 1424667
Change-Id: Ib1ad425bf7537313b7d3104553e4949e403a2e32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4338116
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Prudhvikumar Bommana <pbommana@google.com>
Commit-Queue: Prudhvikumar Bommana <pbommana@google.com>
Cr-Commit-Position: refs/heads/main@{#1117712}