commit | f51bb95784aa8d77ffad577fc26d960a0fcb47eb | [log] [tgz] |
---|---|---|
author | Maggie Cai <mxcai@chromium.org> | Fri May 24 00:07:05 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri May 24 00:07:05 2019 |
tree | 7a54cff56827dc587a7540cf9a277042c82f3d9e | |
parent | 1093fa2a70f85d134671f88d2c5a02ee78c47d03 [diff] |
Only create AppsNavigationThrottle for main frame navigation. Currently we will create app navigation throttle for both main frame and iframe navigations. This causes a issue where if there is a subframe navigation it will overwrite the intent picker icon status that is shown for the main frame. Previously a CL is landed (https://chromium-review.googlesource.com/c/chromium/src/+/1609750) to fix the issue by not showing the icon when there is a iframe. However if a iframe navigation happens it will hide the icon even when the main frame navigation request the icon to show. This CL fixs the issue and adds tests for it. BUG=964802 Bug: b/132641354 Change-Id: Ic7ce20daf4c7c7bd96eb48f112db2fd59214a14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624073 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#662904}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .