Google Git
Sign in
chromium / chromium / src / da3f3cdd384f55e7f289e7b0413c0b4c717d9852
commitda3f3cdd384f55e7f289e7b0413c0b4c717d9852[log] [tgz]
authorFlorian Zubeil <zubeil@google.com>Thu Apr 11 17:50:10 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 11 17:50:10 2024
tree78d41292d2a396291397ea313b34a63bec168417
parenta0583a216550c4ec599518d3911f50f5543fdc4e [diff]
Do not call GetHttpReasonPhrase

https://crrev.com/c/5371447 introduced calling ::net::GetHttpReasonPhrase to map a `response_code` to a string.

However, when no network is present, `response_code` is 0 and ::net::GetHttpReasonPhrase runs into `NOT_REACHED`, which crashes chrome on non-official builds.

Since this mapping seems mostly for convenience, this CL proposed to remove it. Please let me know if you prefer to fix it differently.

Bug: b:333365281
Change-Id: Ife03b30c33bb44d6c18b33302b345647a92c8517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5434994
Reviewed-by: Alberto Juarez <albertojuarez@google.com>
Commit-Queue: Alberto Juarez <albertojuarez@google.com>
Reviewed-by: Steffen Seckler <sseckler@google.com>
Cr-Commit-Position: refs/heads/main@{#1285940}
1 file changed
tree: 78d41292d2a396291397ea313b34a63bec168417
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.