Google Git
Sign in
chromium / chromium / src / f5cbb8d780a8646ca92995167cacce75d19d6205
commitf5cbb8d780a8646ca92995167cacce75d19d6205[log] [tgz]
authorAnand K Mistry <amistry@chromium.org>Fri Oct 15 00:46:15 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Oct 15 00:46:15 2021
tree2ee3b8e701d6f961b0130313492879e3902e2235
parenta6f5710c598be8747f7401cb36e08a5701dbaa09 [diff]
Crostini: Invalidate callback weak ptrs when JS is disallowed

A quick user (or integration test ;) ) could close the resize dialog
before the resize callback is run. Closing the dialog is a navigation
event that disallows JS on the WebUI page. Since JS is disallowed,
running ResolveJavascriptCallback() will then CHECK-fail.

Fix by introducing a second WeakPtrFactory for use with callbacks, and
invaidate the weak pointers when JS is disallowed.

Bug: b:202364091
Change-Id: I8fdb3292eabb635bd038379a632c6c51bd81d654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216294
Commit-Queue: Anand K Mistry <amistry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/main@{#931799}
2 files changed
tree: 2ee3b8e701d6f961b0130313492879e3902e2235
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.