| commit | f5d278294bd410c82e9cca4d873b077a18cc463f | [log] [tgz] |
|---|---|---|
| author | Kenichi Ishibashi <bashi@chromium.org> | Mon Oct 19 00:58:10 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Oct 19 00:58:10 2020 |
| tree | a280088eae2c0c8af57362fc8d8bfb529c62b2a1 | |
| parent | 8bc8d6d35d898aed9b95cbcb87c6b01ca6a2c735 [diff] |
Give ServiceWorkerDiskCache its own implementation
This CL duplicates AppCacheDiskCache{,Entry} into
ServiceWorkerDiskCache{,Entry} to remove the AppCache
dependency from service workers. See [1] for the reasoning of this
duplication.
To avoid risks of behavior changes, this CL only makes minimum tweaks
which includes:
* Address Tricium warnings (use default member initializers, prefer
emplace_back).
* Follow the current coding style guide.
* Remove `use_simple_cache_` flag. It's always true for service workers.
* Add a sequence checker.
Follow-up CLs will do some refactoring like addressing
crbug.com/586174.
[1] https://docs.google.com/document/d/1UhdZnaeEP8GywZR0Gik6wF6jKmNY3je6aDhPfJ05YhU/
Bug: 1117369
Change-Id: Ia62fe55a23c2c84b569516e97e0059994c7755bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452029
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818326}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.