Google Git
Sign in
chromium / chromium / src / f5f75943371a436b619bfab47fd1eb6039a52fad
commitf5f75943371a436b619bfab47fd1eb6039a52fad[log] [tgz]
authorAntonio Sartori <antoniosartori@chromium.org>Fri May 19 12:03:18 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri May 19 12:03:18 2023
tree844b41937c63fd4e0eb231bd2ba5f0fd8113aca4
parent46e638d63b1af782c7e841571dda9d41d8000a26 [diff]
[WPT, CSP] Fix flaky CSPEE allow_csp_from-header.html test

The test had a few small issues causing it to be flaky. In particular,
we were waiting for the onload event + 2 postMessages from the child
for marking the tests as done, however the test would succeed only if
those messages arrived in a predefined order. Moreover, one of the
messages we were awaiting was misspelled in the check ('img.loaded' vs
'img loaded').

This CL is an easy check for those problems. It would be actually good
to think about rewriting this whole test using promises, but that
requires more work. Let's fix the flakiness first.

Bug: 1446669
Change-Id: I1727c54e0f89fd087e3ec01e777d156f6b7eb8ed
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4547659
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Jonathan Hao <phao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1146453}
2 files changed
tree: 844b41937c63fd4e0eb231bd2ba5f0fd8113aca4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.