Revert "[Android][Gardener] Fixing ChromeTabbedActivityTest" This reverts commit d6e5b5782cb0fe2cd98797bf44a849d6f3ece9b9. Reason for revert: The fix didn't help so the test should stay disabled Failed run including the fix: https://ci.chromium.org/ui/p/chrome/builders/ci/android-arm-tests/33243/blamelist Bug: 436750862 Original change's description: > [Android][Gardener] Fixing ChromeTabbedActivityTest > > ChromeTabbedActivityTest#testBackShouldCloseTab_Collaboration was > failing because of a NullPointerException. > > When tabCreator creates a new tab Chrome tries to show an IPH message > related to version updates. The VersionUpdateIphHandler is responsible > for this and needs to get the VersioningMessageController from the > TabGroupSyncService. > > Mock TabGroupSyncService is used in the test, but it doesn't specify > what should happen when getVersioningMessageController() is called. By > default, Mockito returns null. This null controller is then passed > along, leading to the NullPointerException when one of its methods is > invoked. > > Mocking the VersioningMessageController should fix the test. > > Change-Id: If0a752e1a4cc5353d3fd5e3c32975be4ef1dee27 > Bug: 436750862 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6827381 > Owners-Override: Ivana Žužić <izuzic@google.com> > Reviewed-by: Adem Derinel <derinel@google.com> > Commit-Queue: Ivana Žužić <izuzic@google.com> > Auto-Submit: Ivana Žužić <izuzic@google.com> > Cr-Commit-Position: refs/heads/main@{#1498107} Bug: 436750862 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I9f939b82b4c394534c81432ac4928fd8d93163ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6826972 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Adem Derinel <derinel@google.com> Auto-Submit: Ivana Žužić <izuzic@google.com> Owners-Override: Ivana Žužić <izuzic@google.com> Commit-Queue: Adem Derinel <derinel@google.com> Cr-Commit-Position: refs/heads/main@{#1498290}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.