Google Git
Sign in
chromium / chromium / src / f62eea3a07075b3d00b45871c46b284f88f827d8
commitf62eea3a07075b3d00b45871c46b284f88f827d8[log] [tgz]
authorLily Chen <chlily@chromium.org>Thu Aug 24 02:05:28 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Aug 24 02:05:28 2023
tree776aee93eb8e6febe4b50d51062127aba3de22e6
parent8c0314683af50a42ddee47c2405f1041c5a328ce [diff]
[DownloadBubble] Clear model when download is deleted

This nulls out the DownloadUIModel member of DownloadBubbleRowView
when the backing download is destroyed. This is to avoid calling into
a deleted DownloadItem and causing a crash.

The specific crash is due to the RepeatingTimer callbacks, but this adds
null checks everywhere the model is expected to be non-null.

Bug: 1470681
Change-Id: Ic3af736f984065f07a03aebb66040f7cad2c980d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4807031
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1187622}
1 file changed
tree: 776aee93eb8e6febe4b50d51062127aba3de22e6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. weblayer/
  52. clank
  53. internal
  54. ios_internal
  55. native_client
  56. signing_keys
  57. v8
  58. .clang-format
  59. .clang-tidy
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.