Google Git
Sign in
chromium / chromium / src / f630b0d3526a18552fe41cf72bfec465b68ed6b8
commitf630b0d3526a18552fe41cf72bfec465b68ed6b8[log] [tgz]
authorKyle Milka <kmilka@chromium.org>Tue Jan 22 17:31:11 2019
committerCommit Bot <commit-bot@chromium.org>Tue Jan 22 17:31:11 2019
tree45d1e6d08e101bcd222cabf9512a0d45fb9dfa2e
parent5a8638c641e19bf05a84ef850242dbb9fdf568a8 [diff]
Revert "Allow ddljson response to not contain an image"

This reverts commit bf7b0cb7ff8897c1e1160c48dc2dcfca0c37329e.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Allow ddljson response to not contain an image
> 
> Interactive doodles don't use the image (data_uri field) included
> in the ddljson response. Don't require that responses (on Desktop)
> contain an image. Allow logo_cache to cache a doodle that doesn't
> include an image.
> 
> Bug: 800170
> Change-Id: I637ab2130db29efadecebd787c244e59008d3e63
> Reviewed-on: https://chromium-review.googlesource.com/c/1405431
> Commit-Queue: Kyle Milka <kmilka@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623783}

TBR=treib@chromium.org,kmilka@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 800170
Change-Id: Ided4301b88586d21cbb653aefaf75206aa6d2c5d
Reviewed-on: https://chromium-review.googlesource.com/c/1426879
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624813}
9 files changed
tree: 45d1e6d08e101bcd222cabf9512a0d45fb9dfa2e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .