commit | f6514dec62db140da6dae8b5cdaa5c31a07b1504 | [log] [tgz] |
---|---|---|
author | Howard Yang <hcyang@google.com> | Thu Jun 02 17:50:55 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 02 17:50:55 2022 |
tree | 6fe4052ed2c601defee0fcaeb15fd4f8c7799fb1 | |
parent | 2053302da0b48267ddd7faac95a3d1d1d3637964 [diff] |
fido: Implement SupportsEpAtt for CrOS authenticator Currently CrOS authenticator doesn't override the SupportsEnterpriseAttestation method, so it always returns false. Under this condition Chrome will never send a request with attestation preference = "enterprise". The CrOS authenticator actually supports enterprise attestation when U2F/G2F mode is enabled, which is determined by policy and device capability. Check whether U2F mode is enabled when initializing the authenticator and cache the result, and returns it in SupportsEnterpriseAttestation. Bug: b:226453823, 1328415 Test: manual test along with daemon side changes that a MakeCredential request that wants enterprise attestation will get a valid G2F cert instead of a software generated cert. Test: CQ (cherry picked from commit 7c4abafd0d71afb537db1fe76796dda30db54aeb) Change-Id: I33804907e7ce48534a553200d7a27c0fad222d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3659142 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by: Adam Langley <agl@chromium.org> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1006584} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3685870 Auto-Submit: Howard Yang <hcyang@google.com> Cr-Commit-Position: refs/branch-heads/5060@{#492} Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.