commit | f6abd42a5fe16e8a01db9d27d9d3aed7f49e0c01 | [log] [tgz] |
---|---|---|
author | Siarhei Vishniakou <svv@google.com> | Tue Sep 20 23:56:57 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Sep 20 23:56:57 2022 |
tree | e4f01214c1294d3318b2d518b41c99affe78357f | |
parent | 463aa9b057aff1c44f4d3e121bb0071f6775da21 [diff] |
Time-based resampling Currently, we are relying on the number of samples in order to do certain actions, like checking for hold or for running the rejection model. Before this CL, the resampling could end up producing several samples at once. This would cause the actions above to potentially be skipped, because we performed the check of the number of samples before the resampling code ran. An exact match for certain number of samples was performed, so sometimes, palm rejection model would not get executed. In this CL, we change the approach to rely on the time instead. We check whether a specific time threshold is crossed with each sample received from the touchscreen. If it's crossed, then the action is taken. Additional changes here: 1) All samples are now stored in unmodified manner. 2) It's possible to exceed max_sample_count when resampling is enabled 3) samples_seen() is replaced with Duration() 4) When a resampled value is needed, we get getSampleAt(time). The resampled value is never stored. 5) Old variables such as last_sample and old function Resample were deleted 6) We are now storing the first sample's timestamp in first_sample_time. It's needed to calculate the duration of the stroke, since at some point, we will drop the first sample After this change, any references to samples_seen and samples().size() should consider the resampled and non-resampled cases. Therefore, the "Filter" function should not directly check the number of samples anywhere. Bug: b/240168494 Change-Id: I983aa93ce7ae352aca748d4bbab8fd2d1af28df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3857630 Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Reviewed-by: Rob Schonberger <robsc@chromium.org> Auto-Submit: Siarhei Vishniakou <svv@google.com> Reviewed-by: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/main@{#1049397}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.