Google Git
Sign in
chromium / chromium / src / f6b23b582e63589f0cc9b121ab10b5d4c01cb7cb
commitf6b23b582e63589f0cc9b121ab10b5d4c01cb7cb[log] [tgz]
authorAlex Newcomer <newcomer@chromium.org>Thu Nov 04 00:44:32 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 04 00:44:32 2021
tree73f4e09801e7f77d7ad08689a24dadc63b834d47
parentc4780653d5073047aa7ef90d837b0dac278cf6b0 [diff]
Use WeakPtr to prevent using the ptr out of scope

When switching to AnimationBuilder, we passed
a callback instead of using the old
ImplicitAnimationObserver pattern.
ImplicitAnimationObserver removes itself on its
dtor. Meanwhile AnimationBuilder has a dangling
ptr.

Using a WeakPtr should fix this crash (but I
cannot repro it, so this fix is technically
speculative).

Bug: 1265741
Change-Id: I234621cfd780c93b47c1a11aa67945075f2e9632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3260120
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#938078}
1 file changed
tree: 73f4e09801e7f77d7ad08689a24dadc63b834d47
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.