commit | f6d0d815a0a07039f330a2252c0b3927622da85d | [log] [tgz] |
---|---|---|
author | Joel Hockey <joelhockey@chromium.org> | Wed Apr 16 05:03:19 2025 |
committer | Joel Hockey <joelhockey@chromium.org> | Wed Apr 16 05:03:19 2025 |
tree | 44e753155034d2d88259f1882affccd06419ae45 | |
parent | 792ab54dfd4815d72a6c649d8f7c6696196405bc [diff] |
Reland "Revert "[CHAP] MVP for Browser initiated automatic picture in picture"" This reverts commit 27c7fe778d6af5556f2d32b1dcae2611e6d602e9. Reason for revert: dep http://crrev.com/c/6437622 now reverted, so this can be reverted again Bug: 408502322, b/318568892 Bug: 408502322, b/318568892 Original change's description: > Revert "Revert "[CHAP] MVP for Browser initiated automatic picture in picture"" > > This reverts commit e6df4ccca639ed51e5f324bf07af17d86f267015. > > Reason for revert: > LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8717469088215473265 > > Sample failed build: https://ci.chromium.org/b/8717469088215473265 > > If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6459564&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8717469088215473265&type=BUG > > Original change's description: > > Revert "[CHAP] MVP for Browser initiated automatic picture in picture" > > > > This reverts commit 917b12aef63ee6f3aedcef6ee20b3c3fbd21b2e6. > > > > Reason for revert: Cause of deterministic failure on Win10 Tests x64 bot. First failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64/99652/overview > > > > Bug: 408502322, b/318568892 > > Original change's description: > > > [CHAP] MVP for Browser initiated automatic picture in picture > > > > > > Bug: 408502322, b/318568892 > > > Change-Id: I0911bb517e42ab0572b630f192066d256c90852d > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6443412 > > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > > Commit-Queue: Benjamin Keen <bkeen@google.com> > > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#1447331} > > > > Bug: 408502322, b/318568892 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Change-Id: I652587d04a160627bfe252b6581e372c930a5525 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6459564 > > Owners-Override: Ken Okada <kenoss@chromium.org> > > Commit-Queue: Ken Okada <kenoss@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/main@{#1447520} > > > > Bug: 408502322, b/318568892 > Bug: 408502322, b/318568892 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I2dad50b92ed795438dc77a2380b2af064ca1a079 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6461093 > Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> > Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> > Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1447523} Bug: 408502322, b/318568892 Change-Id: I9b8492f81b6630c13bea254970255bb9f9450c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6457950 Owners-Override: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Benjamin Keen <bkeen@google.com> Cr-Commit-Position: refs/heads/main@{#1447545}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.