Update Inline Reply for CrOS As a part of the notification refresh effort... 1. A slight refactor to enable the refresh for CrOS - Pull out the inline reply(NotificationInputContainer) from NotificationViewBase. - Add an Init() to NotificationInputContainer to ensure derived class functions are called during view construction. - Move a function used by NotificationInputContainer and NotificationViewBase into a notification util file. 2. The meat of the UI Refresh changes for CrOS - Create an AshNotificationInputContainer for chromeos notifications with styling that matches the spec. In another CL I will... - Change the send icon - Change focus highlights - Adjust actions row font and spacing - Animations for to/from showing inline reply Screenshots: Old UI on CrOS with feature disabled https://screenshot.googleplex.com/BUo7UEmxuA2ot5U.png https://screenshot.googleplex.com/745G9j7yYtsrrsa.png New UI(notifications refresh enabled)before changes of this CL: https://screenshot.googleplex.com/6HdUeG3cVKBPv2Y https://screenshot.googleplex.com/AwDmnQ6tKALGPJn New UI with changes from this CL: https://screenshot.googleplex.com/BEeDQ3jyg5hfJp2 https://screenshot.googleplex.com/5G8Hka9dMURiYff Bug: 1233660 Change-Id: I57f779226e6e9cc2f5978c7ebe34520305c32184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3150136 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/main@{#921802}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.