Reland "[views-ax] Migration of kName attribute in Tab" This is a reland of commit 1eadd223cce221615fa18db6647451a26a0315a2 A bug (Bug: 374947846) was introduced on MAC where, after setting the window title, the custom window name was not included in the window title in the task switcher. In the above CL, I updated the logic in GetAccessibleTabLabel to not depend on window_title while computing the tab label. The same logic was applied to compute the window label, which caused this issue. GetAccessibleWindowTitleForChannelAndProfile relies on GetAccessibleTabLabel to include the custom window title information. There is already a parameter is_for_tab that indicates whether the title is requested for a tab or a window. Original change's description: > [views-ax] Migration of kName attribute in Tab > > This CL migrates the kName attribute in views to be updated > whenever its value should change, rather than querying the value > and computing it only when needed. > > As part of this change, the following views are updated: > Tab, BrowserView, PermissionChipView, and TabSlotView. The Tab > class extends TabSlotView. BrowserView::GetAccessibleTabLabel > constructs the accessible name for a tab by gathering various > properties such as the title, group, memory usage, and possibly > other elements like permission chips, to create a comprehensive > and accurate label. > > This CL is part of the ViewsAX project: > https://docs.google.com/document/d/1Ku7HOyDsiZem1yaV6ccZ-tz3lO2XR2NEcm8HjR6d-VY/edit#heading=h.ke1u3utej413 > > Bug: 325137417 > Change-Id: Id1ca1da2e970c82575dff12bd48434f716d4548f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5836477 > Reviewed-by: Jacques Newman <janewman@microsoft.com> > Commit-Queue: Gaurav Kumar <gauravkum@microsoft.com> > Reviewed-by: Elly FJ <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1367340} Bug: 325137417 Change-Id: If364f5b13f4e684a3a78a65886d73e16aa357c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5982222 Reviewed-by: Elly FJ <ellyjones@chromium.org> Reviewed-by: Jacques Newman <janewman@microsoft.com> Commit-Queue: Gaurav Kumar <gauravkum@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1383126}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.