Assert that WebUI JS test name length doesn't exceed ResultDB limit

The goal is to have WebUI JS tests fail locally if the test name is long
enough to exceed ResultDB's 512 byte limit on test identifiers.

The test identifier consumed by result_adapter is constructed in
//base/test/launcher/test_results_tracker.cc, which produces the JSON
that is consumed by result_adapter. This poses two problems:

  1. Failure at this stage is undetectable outside of a LUCI context
     (i.e. in local test runs)
  2. GTest code can't know how the final test identifier is constructed

To achieve the stated goal in light of problem 1, we must add an
assertion in WebUIMochaBrowserTest so that the test will fail locally if
the name is going to exceed the 512 byte limit imposed by ResultDB.

Because of problem 2, this guardrail can't be exact, and may become
stale.

These shortcomings are acknowledged in order to attain fast failure.

Bug: 393139276
Change-Id: Id4fde82a144c40a7f80e4071b710188bc85b880a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6384039
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Alex Yang <aycyang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1443725}
5 files changed
tree: e923242e3a9aac6ff09abaa7ba5230a7c690ed97
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.