CrOS Settings: Fix settings search field focus loss issue The value of `showingSearch` is only the indicator of showing the search field or not when it's at narrow status. The change of showingSearch's value shouldn't manually invoke the focus / blur on `searchInput`. Thus, this CL removes the function `showingSearchChanged_`. The only place we need to manually call focus is when search icon is clicked in the narrow state since the searchInput is hidden at the moment. The only place we need to manually call blur is when `escape` key is pressed. Screen records: . before fix: https://screencast.googleplex.com/cast/NTE1NjA4NTc5NDA3ODcyMHwyZmM5N2YzMi1lMQ . after fix: https://screencast.googleplex.com/cast/NjM2MTc5OTUzMTE2Nzc0NHwwYzAyMzI5Ni1mZQ Bug: b/316019447 Change-Id: Iafda5ad9f0d1e0ebe57e29c34b3e5afa22930dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190830 Reviewed-by: Wes Okuhara <wesokuhara@google.com> Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: Connie Xu <conniekxu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1249719}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.