CrOS Settings: Fix settings search field focus loss issue

The value of `showingSearch` is only the indicator of showing the search
field or not when it's at narrow status. The change of showingSearch's
value shouldn't manually invoke the focus / blur on `searchInput`. Thus,
this CL removes the function `showingSearchChanged_`.

The only place we need to manually call focus is when search icon is
clicked in the narrow state since the searchInput is hidden at the
moment. The only place we need to manually call blur is when `escape`
key is pressed.

Screen records:
 . before fix:
https://screencast.googleplex.com/cast/NTE1NjA4NTc5NDA3ODcyMHwyZmM5N2YzMi1lMQ
 . after fix:
https://screencast.googleplex.com/cast/NjM2MTc5OTUzMTE2Nzc0NHwwYzAyMzI5Ni1mZQ

Bug: b/316019447
Change-Id: Iafda5ad9f0d1e0ebe57e29c34b3e5afa22930dc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190830
Reviewed-by: Wes Okuhara <wesokuhara@google.com>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Connie Xu <conniekxu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1249719}
3 files changed
tree: c26747aa132c908347a241ed1a0a0d77af9c6661
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.