commit | f71cd6c3dfc60d724e769c2d0e70a8d42196847a | [log] [tgz] |
---|---|---|
author | Dan Clark <daniec@microsoft.com> | Wed Jun 22 19:48:01 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 22 19:48:01 2022 |
tree | 66f9cd78dd8371fae99ac6330d4ca7727d1c1601 | |
parent | 9d940d1f068c8760504698a3f8763625b3f32b4d [diff] |
Add missing dep for web_test_web_frame_widget_impl.obj The web_test_web_frame_widget_impl.obj target is missing a build dependency on mojom headers generated from //device/gamepad/public/mojom. These headers are a public_dep of //content/web_test:web_test_renderer, but due to crbug.com/1154721 they're not getting transitively propagated to web_test_web_frame_widget_impl. This can result in flaky builds; the build will fail if web_test_web_frame_widget_impl.obj tries to build before something else builds the dependency creating the mojom headers. This can be observed by deleting the build directory, recreating it, and running autoninja obj/third_party/blink/renderer/core/web_test/web_test/web_test_web_frame_widget_impl.obj This CL adds the missing dependency to //content/web_test:web_test_common_mojom, ensuring that it gets pulled in by web_test_web_frame_widget_impl's existing dependency on //content/web_test:web_test_common. Bug: 1336389, 1154721 Change-Id: I4fdef5876e1656fcdd6583f39ce0c44770384baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3703162 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1016837}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.