commit | f75a0c1c88419119a4d92122c7892b5b2ec0de9e | [log] [tgz] |
---|---|---|
author | Anatoliy Potapchuk <apotapchuk@google.com> | Wed Apr 14 12:46:13 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 14 12:46:13 2021 |
tree | b4e3259c9b4e92ae23c841983151d94041407c21 | |
parent | 13a3d41f92b643ff8b5b00985c7c34baf38d4902 [diff] |
[Sheriff] Revert "New object attributes to disambiguate description sources" This reverts commit 80e972425d5b8c543aa934d8afce64e4d8e5aeda. Reason for revert: Suspected to cause a11y tree failures, https://ci.chromium.org/ui/p/chromium/builders/ci/Win7%20Tests%20(1)/116006/overview Original change's description: > New object attributes to disambiguate description sources > > NVDA screen reader team has asked for some changes to how descriptions > are exposed in IAccessible2 so that they don't have to automatically > announce tooltips, while still announcing other annotations. > > New object attributes: > * "description" now reflects aria-description, but not other description > sources. This matches what Firefox does now. > * "description-from" has one one the following values: > - "aria-description" > - "aria-describedby" > - "ruby-annotation" > - "summary" > - "table-caption" > - "tooltip" (either via @title or aria-describedby + role="tooltip") > - "button-label" (when the name was from something else) > > The above may require future tweaks but has been agreed to in principle > with NVDA and Mozilla. > > Bug: 1194991 > Change-Id: Ie20486e569b6f892e85c143119d1eea4d91efaf7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2799998 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#871966} Bug: 1194991 Change-Id: I34b222fe6ebcebbf788b8e1825f8920d2d8b00d0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2825893 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Anatoliy Potapchuk <apotapchuk@google.com> Auto-Submit: Anatoliy Potapchuk <apotapchuk@google.com> Cr-Commit-Position: refs/heads/master@{#872385}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.