| commit | f78a38c4c438cb27e3c6b7ef00a3fd4f77862a70 | [log] [tgz] |
|---|---|---|
| author | Xiaohan Wang <xhwang@chromium.org> | Wed Dec 20 18:41:13 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Dec 20 18:41:13 2023 |
| tree | c5080c3341123c0c10fae9a2deb4140bd9f58d99 | |
| parent | f709a264e9ed8c2feb16ffd890cfe95b9b7deb2c [diff] |
Only show "Open in reading mode" for selected item groups Since "Open in reading mode" is for opening the current page in reading mode, this option should only be used for selected item groups. This CL updates the code to only show this option for page content, smart selection (selections without links), and editables. This is to avoid the confusion on link/image/video etc since we are not opening them in reading mode. Bug: 1266555 Fixed: 1504360 Test: Unit test updated and manually tested. Change-Id: I62f8b136104ea1b5df8815863fa57dc2b086371d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5132566 Reviewed-by: Abigail Klein <abigailbklein@google.com> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1239766}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.