Enforce Peek() before Consume(). In the streaming parser, you can never Consume() without knowing that you will not consume a block start token. Enforce this with a DCHECK (which, incidentally, found two such bugs). It will not take everything (e.g., there is still at least one calc() parsing bug left), but at least requires more complicated patterns to create such bugs. Change-Id: I60191c874b8981479cc983e17fc958e2a6eeb66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5861248 Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1356975}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.