Google Git
Sign in
chromium / chromium / src / f7ccd135a45965517dc06d330776e9560202b271
commitf7ccd135a45965517dc06d330776e9560202b271[log] [tgz]
authorTorne (Richard Coles) <torne@google.com>Fri Mar 25 16:45:26 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Mar 25 16:45:26 2022
treee8eddb393f3fa52bed7933003b8e6e0f3815263a
parentc7dc2aac4a32cc5fd7d05fba88bf0b7d2fe78803 [diff]
webview: close streams in NetworkFetcherTask.

Use try-with-resources to ensure streams are closed properly in
NetworkFetcherTask; some of these were missing.

Also increase the buffer size to 8KiB; 1KiB is smaller than a page which
isn't great for IO. FileUtils.copyStream (which isn't used here because
of the JNI progress callback) uses 8KiB.

Bug: 1310064
Change-Id: I41d7f72aaa78ffa9eecb1df52a741dd6a99317b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3553279
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/main@{#985334}
1 file changed
tree: e8eddb393f3fa52bed7933003b8e6e0f3815263a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.