commit | f7d47b7e8c03400343d4b6753ff79ade9d09ca68 | [log] [tgz] |
---|---|---|
author | Takuto Ikuta <tikuta@chromium.org> | Wed Jun 20 14:41:09 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jun 20 14:41:09 2018 |
tree | 807b22eb8081aaae1e7e42aac4874b9cc2ab2eda | |
parent | 3f5f5357f3e990d932830ed3663ae6144035ca00 [diff] |
Do not use tool-wrapper for lld link When building chrome on windows, tool-wrapper for linking is called 794 times. And I found that calling python wrapper is relatively slow than calling link via ninja. This CL replaces python wrapper to ninja wrapper to remove such overhead when we use lld. I compared time of wrapper invocation using following powershell script. for ($i = 0; $i -lt 100; $i++) { # ninja -t msvc -e environment.x64 -- C:/src/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe -c ' ' # python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False C:/src/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe -c ' ' # code for FlushFileBuffers is commented out. } * ninja wrapper, 7.451s for 100 invocation * python wrapper, 17.803s for 100 invocation Using ninja as env wrapper is more than 2 times faster. Bug: 787903 Change-Id: I6531b59a6c43085782b0138a264ecfc9a6f65833 Reviewed-on: https://chromium-review.googlesource.com/1107678 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#568836}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .