Google Git
Sign in
chromium / chromium / src / f7f07479db3a0bbabe8b58aec4f004b2ce707433
commitf7f07479db3a0bbabe8b58aec4f004b2ce707433[log] [tgz]
authorZhixiang Teoh <zhteoh@google.com>Wed Jun 01 22:17:45 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jun 01 22:17:45 2022
tree8b80e3b37a3d4702e42646caa61d41cee2dbdfb4
parentde66d3de83d6b7bf556caf59cf442b8803a13dde [diff]
Record PageLoad metrics w/ TranslateMetricsLogger

Added and translate_metrics_logger_ private member following TranslatePageLoadMetricsObserver. Correspondences:
DidStartNavigation <-> OnStart, DidFinishNavigation <-> OnCommit, DidStartNavigation/WebStateDestroyed <-> OnComplete.

TranslateMetricsLogger lifetime tied to page load via ChromeIOSTranslateClient::DidStartNavigation.

(cherry picked from commit dd427e94a0a05152993d0b31d341a32d1145a5b8)

Bug: 1326717
Test: Build iOS simulator, run Chromium, navigate to chrome://histograms/Translate.PageLoad, then any website in a new tab, then refresh chrome://histograms/Translate.PageLoad tab. Automated unit tests: build and run ios_chrome_unittests with --gtest_filter="ChromeIOSTranslateClientTest.*" flag.
Change-Id: Ie7652a2545f094e4226abd0820a5b2020460baa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3662122
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Trevor Perrier <perrier@chromium.org>
Reviewed-by: Raj T <rajendrant@chromium.org>
Commit-Queue: Zhixiang Teoh <zhteoh@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1008509}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3684613
Commit-Queue: Raj T <rajendrant@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#470}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
4 files changed
tree: 8b80e3b37a3d4702e42646caa61d41cee2dbdfb4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.