Google Git
Sign in
chromium / chromium / src / f854c1102b97b69f98f1bcf426d4465cb010ed9c
commitf854c1102b97b69f98f1bcf426d4465cb010ed9c[log] [tgz]
authorLuciano Pacheco <lucmult@chromium.org>Mon Aug 02 04:39:39 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Aug 02 04:39:39 2021
tree6e3d95176404cb801d7e0926013c2bdbf5d58d8e
parentcad640a7a872394a132078faa681f41a8d433b61 [diff]
Files SWA: Allow clipboard access for Files SWA

The execCommand() fails for some commands in the SWA (System Web Apps)
context.  This CL allow list Files app SWA for the
AllowReadFromClipboard() check.

Reducing the allow list to only:
*  Files SWA
*  AllowReadFromClipboard() which is used for the `paste` command.

NOTE: This only allows list in the renderer side. In the browser side
this is currently default-allowed for legacy reasons:
https://bit.ly/3zQSVY1

NOTE #2: This is a temporary workaround and the permanent solution is
to migrate to Clipboard API which has support for properly granting
permissions for SWAs.

Bug: b/191831968 b/193686962 chromium:1233395
Test: browser_tests --gtest_filter="Transfer/FilesAppBrowserTest*"
Change-Id: I90326e77efab7947014abbb224ba890b3af01bc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992804
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bo Majewski <majewski@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#907449}
5 files changed
tree: 6e3d95176404cb801d7e0926013c2bdbf5d58d8e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.