[PWA/Nav capturing] Fix crash with focus-existing PWAs from intent icon

Currently, the link capturing flow for reparenting an app by clicking
on the intent picker icon will crash Chrome if the app has a launch
handler of focus-existing or navigate-existing. This is because of an
UAF in the WebAppsIntentPickerDelegate triggered by the reparenting
logic which handles these launch handlers separately by destroying
the old web contents [1].

Destruction of web contents destroys the IntentPickerTabHelper which
owns the delegate, which means WebAppsIntentPickerDelegate::LaunchApp()
crashes while trying to reference any class variables.

This CL fixes that by creating an overload of the reparenting function
that takes in a callback, and runs it with the web contents that
are created as part of the reparent flow. By doing so, the final
resultant web contents are always used to perform logic in, and if
things needed to be done with it, that can happen inside a callback.

The reparenting call cannot itself be asynchronous, because it is
triggered from the menu model under the IDC_OPEN_IN_PWA_WINDOW
command. That has been maintained with the current implementation.

[1] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/web_applications/web_app_launch_utils.cc;l=440;drc=451093bbaf7fe812bf67d27d760f3bb64c92830b;bpv=1;bpt=1

Bug: 359224477, 356165283
Change-Id: If417433fd076a8f739adcd05e576c8931dd885c8
Include-Ci-Only-Tests: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5862344
Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1356199}
9 files changed
tree: 4b409b6f18ef45703114d801d62a10773806d5a3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitallowed
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. CPPLINT.cfg
  70. CRYPTO_OWNERS
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.